We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cesium's implementation of the KHR_texture_transform extension of glTF makes poor assumptions that the optional sampler will be defined.
KHR_texture_transform
sampler
https://github.com/AnalyticalGraphicsInc/cesium/blob/90b130edea858b7b6b6a1575422b0b2654f2ae97/Source/Scene/processPbrMaterials.js#L94
In the above, gltf.samplers need not be defined, and gltf.textures[n].sampler is likewise optional, leading to a rather fancy message:
gltf.samplers
gltf.textures[n].sampler
Cannot read property 'undefined' of undefined
Here's a sample model for testing.
TexRotateTest.zip
The text was updated successfully, but these errors were encountered:
So it looks like the behavior is to have repeatS/repeatT be false if there's no sampler?
Sorry, something went wrong.
No, the default wrapping value in glTF is REPEAT, so when not specified, repeat should be true.
REPEAT
Successfully merging a pull request may close this issue.
Cesium's implementation of the
KHR_texture_transform
extension of glTF makes poor assumptions that the optionalsampler
will be defined.https://github.com/AnalyticalGraphicsInc/cesium/blob/90b130edea858b7b6b6a1575422b0b2654f2ae97/Source/Scene/processPbrMaterials.js#L94
In the above,
gltf.samplers
need not be defined, andgltf.textures[n].sampler
is likewise optional, leading to a rather fancy message:Here's a sample model for testing.
TexRotateTest.zip
The text was updated successfully, but these errors were encountered: