Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IDL intersection of rhumb lines by using the correct sign of PI #7551

Merged

Conversation

shehzan10
Copy link
Member

Before this fix, the intersection depended on which sign of PI was being used, and as a result of rhumb lines being spirals, a non-first latitude was being returned.

Added a spec to ensure this.

@likangning93 would you do the honors?

@shehzan10 shehzan10 force-pushed the rhumb-line-IDL-intersection-fix branch from 935d17f to a4eb129 Compare February 7, 2019 22:09
@shehzan10
Copy link
Member Author

This can also be tested using the Drawing on Terrain sandcastle and adding arcType: Cesium.ArcType.RHUMB to the line entity at line 27.

@cesium-concierge
Copy link

cesium-concierge commented Feb 7, 2019

Thanks for the pull request @shehzan10!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

Copy link
Contributor

@likangning93 likangning93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shehzan10 just the one comment, otherwise this looks good. Thanks!

Specs/Core/EllipsoidRhumbLineSpec.js Show resolved Hide resolved
@shehzan10
Copy link
Member Author

@likangning93 Updated.

@likangning93
Copy link
Contributor

Thanks @shehzan10!

@likangning93 likangning93 merged commit f87fbad into CesiumGS:master Feb 8, 2019
@shehzan10 shehzan10 deleted the rhumb-line-IDL-intersection-fix branch February 8, 2019 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants