Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model fails to load if some primitives are Draco encoded and others are not #7383

Closed
lilleyse opened this issue Dec 4, 2018 · 5 comments
Closed

Comments

@lilleyse
Copy link
Contributor

lilleyse commented Dec 4, 2018

I can't share the data publicly, but I have a glTF that contains two primitives, one with triangles and the other with lines, and only the triangles are Draco encoded. The code assumes that if the extension is present then all primitives are Draco encoded, which causes a failure when processing the lines.

@lilleyse
Copy link
Contributor Author

lilleyse commented Dec 6, 2018

This happened with another model that had both lines and triangles.

@mramato
Copy link
Contributor

mramato commented Dec 11, 2018

@lilleyse @ggetz Any guess on how easy this will be to fix? Seems like it's starting to pop up more often.

@ggetz
Copy link
Contributor

ggetz commented Dec 14, 2018

We check each primitive for the extension before attempting to decode: https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/Scene/DracoLoader.js#L180

Then throughout we check if there's decoded data associated with the primitive, and use that: https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/Scene/Model.js#L2549

This would be a matter of making sure the resources for the primitives without the extension are loaded and used properly.

@lilleyse
Copy link
Contributor Author

Also came up in #7495.

@OmarShehata
Copy link
Contributor

There's a sample glTF in that issue above ^ so it should make it easier to confirm that this works when we have a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants