Entity flickers when using availability

[OmarShehata]

Open this Sandcastle, speed up the time, and pause it once you start to see flickering.

Came up on the forum. It looks like availability.contains(time) inside Entity.prototype.isAvailable is returning true even after the time is outside the range. More strangely, it alternates between true and false even when the input time does not change?

[hpinkos]

@OmarShehata the use of setInterval in this sandcastle example doesn't make sense. It's adding a new polyline each second the example is running. I'm pretty sure the problem is with the end user code, not with Cesium. I couldn't reproduce the problem using a for loop to add lines.

[cesium-concierge]

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/forum/#!topic/cesium-dev/wtcrYum0dTA

If this issue affects any of these threads, please post a comment like the following:

The issue at #7048 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.

---

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

[OmarShehata]

@hpinkos why does using setInterval not make sense? The scenario this is simulating is data that comes from a server, so it wouldn't all be available from the beginning. Why does it matter when the entities are created? I feel like the fact that adding new entities causes other entities with availability whose end time has passed to be visible again is a bug.

I think this is the expected behavior. My workaround here is removing the entities after their availability is up.

[hpinkos]

@OmarShehata I'm sorry, you're right. I was thrown off by how the example was written. I've created a minimal version to reproduce the problem here: Example

Every time you press the add sample button it does show lines that are past the availability.

[mramato]

@hpinkos did you fix a similar bug that had to do with outdated show properties being used when the primitives are re-created? This could be a similar issue where show isn't updated until after the first render instead of using the current value at creation time.

[cleroux]

I'm the original poster on the forums.

This PR fixes a regression caused by #6835 which resolved issues #2909, #4714, #6830, and #5371.
I confirmed each of these issues and they are all fixed with this PR.

I was reluctant to create a pull request that removes this code because there must be a reason why it exists. I still can't figure that out. But I've run every test I can and everything seems to work OK.

[cesium-concierge]

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/forum/#!topic/cesium-dev/wtcrYum0dTA

If this issue affects any of these threads, please post a comment like the following:

The issue at #7048 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.

---

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏