Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Globe Materials not compatible with enableLighting = false #6042

Closed
YousefED opened this issue Dec 10, 2017 · 9 comments
Closed

Globe Materials not compatible with enableLighting = false #6042

YousefED opened this issue Dec 10, 2017 · 9 comments

Comments

@YousefED
Copy link

Closely related to #6039, but use-case is different nevertheless so decided to open a separate issue (cc @lilleyse as he might be working on this already).

Steps to reproduce:

Result: shader compilation fails

Desired result: not have any time-of-day lighting effects, but still be able to use a globe material for slopes / heights.

@hpinkos
Copy link
Contributor

hpinkos commented Dec 12, 2017

Thanks @YousefED! I thought we fixed this before we merged in globe materials, but we must have missed something.

@lilleyse @jasonbeverage I marked this as 'next release'. If we have time, we should try to address this for 1.41

@lilleyse
Copy link
Contributor

I plan on tackling this along with #6039

@pjcozzi
Copy link
Contributor

pjcozzi commented Dec 17, 2017

Thanks again for the report @YousefED! This is fixed in #6063.

For line 7, I think you mean set it to false, not true. Let me know if I am mistaken.

Also, since globe materials are a new features, please post some screenshots if you are able to share your work; we would love to see it. 😄

@pjcozzi pjcozzi closed this as completed Dec 17, 2017
@YousefED
Copy link
Author

YousefED commented Dec 20, 2017

@pjcozzi correct.

I'm not using globe materials directly, but experimenting with code based on it to generate snow ⛄️ 😎

original
image

snow:
image

@jasonbeverage
Copy link
Contributor

jasonbeverage commented Dec 20, 2017 via email

@pjcozzi
Copy link
Contributor

pjcozzi commented Dec 21, 2017

@YousefED very nice!!! Also, check out some Cesium snow work my students did this past semester: https://github.com/HuYuxin/CIS565FinalProjectCesiumSnow/blob/master/CIS565FinalProjectREADME.md

@jasonbeverage contributions welcome, as always! 😄

@YousefED
Copy link
Author

@pjcozzi awesome!! Are there more projects online? I missed the livestream (time difference)!

@pjcozzi
Copy link
Contributor

pjcozzi commented Dec 22, 2017

Yes, they are all here: https://cis565-fall-2017.github.io/studentwork.html

@mogmog
Copy link

mogmog commented Apr 14, 2020

are there any code samples out there to do this kind of snowy rocky texture? That screenshot of @YousefED looks amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants