Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataSourceClock should not modify properties on Clock that are undefined #4029

Closed
shunter opened this issue Jun 17, 2016 · 0 comments
Closed

DataSourceClock should not modify properties on Clock that are undefined #4029

shunter opened this issue Jun 17, 2016 · 0 comments
Labels
good first issue An opportunity for first time contributors type - bug

Comments

@shunter
Copy link
Contributor

shunter commented Jun 17, 2016

Mentioned in #4007.

Currently DataSourceClock sets all properties on the given Clock in getValue. A default-constructed DataSourceClock will have all properties undefined which will end up breaking the clock. Instead, DataSourceClock should only copy defined values onto the actual clock instance.
@shunter shunter added type - bug good first issue An opportunity for first time contributors labels Jun 17, 2016
@pjcozzi pjcozzi mentioned this issue Dec 24, 2016
Merged
@pjcozzi pjcozzi closed this as completed Dec 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue An opportunity for first time contributors type - bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shunter @pjcozzi