Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session cookies cleared when http file is edited #77

Closed
thegruffalo opened this issue Oct 13, 2021 · 2 comments
Closed

Session cookies cleared when http file is edited #77

thegruffalo opened this issue Oct 13, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@thegruffalo
Copy link

I have an API that I regularly use that requires a login. The login returns session cookies which need to be passed on subsequent requests.

If I have a file with two requests, one to login and one to retrieve some data. I can run both requests (Send All) or run each individually and it all works well. If after sending my login request I edit the .http file the session cookies are cleared.

I would like to be able to tweak my requests in the http file without having to send my login request every time that I do. I don't remember encountering this when I first started to use the VSCode extension some months ago.

@AnWeber
Copy link
Owner

AnWeber commented Oct 13, 2021

There is a bug in the program. In htttpyac I compare if the same rootPath is used and take the cookies accordingly or use a new n MemoryStore. The rootDir can be either a string (CLI) or a vscode.URI (vscode extension). But you cannot compare vscode.URI using ==. The editing of the file, creates a new vscode.URI reference and this causes the bug.
It seems to me like vscode has changed here, as I've only recently become aware of the bug. I already had this elsewhere

@AnWeber AnWeber added the bug Something isn't working label Oct 13, 2021
@AnWeber
Copy link
Owner

AnWeber commented Oct 15, 2021

I have released update 4.3.0 that fixes this error. Please let me know if you still get this error. Otherwise, thanks for using my extension.

@AnWeber AnWeber closed this as completed Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants