Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopped tests show as successful #323

Closed
alekdavisintel opened this issue Aug 29, 2024 · 1 comment
Closed

Stopped tests show as successful #323

alekdavisintel opened this issue Aug 29, 2024 · 1 comment

Comments

@alekdavisintel
Copy link

If I run a long running test (say, I ran the request and I am debugging server code locally) and click the Cancel Test Run button (the rectangle thing next to the TESTING view header), the test icon shows as green check mark to indicate that the test was successful, while it was not (basically, the testy/request did not complete).

image

Not a big deal, since when cancelling the run, one would know that it was not completed, but still.

AnWeber added a commit to AnWeber/httpyac that referenced this issue Nov 3, 2024
@AnWeber
Copy link
Owner

AnWeber commented Nov 3, 2024

cancelation of test run did not work correctly. I registered my cancellation logic on the token provided by the test api. but I needed to use token provided by test run object. I also forgot to add skipped test result if user canceled the executation.

@AnWeber AnWeber closed this as completed Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants