Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#265 breaks folding of json responses #269

Closed
bohni opened this issue Mar 21, 2024 · 7 comments
Closed

#265 breaks folding of json responses #269

bohni opened this issue Mar 21, 2024 · 7 comments

Comments

@bohni
Copy link

bohni commented Mar 21, 2024

With Release 6.12.0 it is not possible anymore to fold JSON responses in output window

Try

GET https://httpbin.org/json
Accept: application/json

with 6.11.6 I get the folding marks on mouse hover:
image

with 6.12.0 those marks don't appear.
image

@AnWeber
Copy link
Owner

AnWeber commented Mar 25, 2024

Every now and then I should read the docs in full. The standard behavior with indentation is deactivated by the custom FoldingRangeProvider. I have now created my own IndentationFoldingRangeProvider, which I use for the indented areas.

@AnWeber AnWeber closed this as completed Mar 25, 2024
@bohni
Copy link
Author

bohni commented Apr 12, 2024

Hi,

unfortunately, the fix hasn't had the desired effect. Even with v6.12.1 I still can't see the markers.

@AnWeber AnWeber reopened this Apr 12, 2024
@AnWeber
Copy link
Owner

AnWeber commented Apr 14, 2024

@bohni Hello, it seems to work for me. Do you have an example or special settings?
image
image

@bohni
Copy link
Author

bohni commented Apr 14, 2024

Hi,
sorry for the noise... I tested on another setup and there I get those markers, too.
Will check my faulty setup and repot back, if I found the reason.
Thanks!

@AnWeber
Copy link
Owner

AnWeber commented Apr 14, 2024

Do you use response output format exchange With this setting I found broken folding

@bohni
Copy link
Author

bohni commented Apr 15, 2024

Yes, you're right. I have responseViewContent set to exchange. Without that setting (using default) folding is working.

@AnWeber
Copy link
Owner

AnWeber commented Apr 19, 2024

is fixed with this commit 4977f82. I will release fix with next release

@AnWeber AnWeber closed this as completed Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants