Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@import should trim the file name #150

Closed
bugybunny opened this issue Sep 15, 2022 · 2 comments
Closed

@import should trim the file name #150

bugybunny opened this issue Sep 15, 2022 · 2 comments

Comments

@bugybunny
Copy link
Contributor

bugybunny commented Sep 15, 2022

If a line with @import contains a space after the file name the file is not found
image
because it searches for "../myfile.http " literally. A trim would be nice because those spaces are hard to see — and not recognizable in the error message — and it seems counterintuitive to include them if I am not missing a good reason to really include the space(s) in the lookup for the file.

If it's on purpose we should mention it in the docs https://httpyac.github.io/guide/variables.html#import-variables.

AnWeber added a commit to AnWeber/httpyac that referenced this issue Sep 15, 2022
@AnWeber
Copy link
Owner

AnWeber commented Sep 15, 2022

No, not intentional, but never fallen over it either. Probably because I have enabled files.trimTrailingWhitespace. I adjusted the parsing in this and a few other places.

@AnWeber
Copy link
Owner

AnWeber commented Sep 19, 2022

released with v5.7.2

@AnWeber AnWeber closed this as completed Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants