Refactored SVG widget and button and improved drag container #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a custom SVG widget that can be styled via the widget background. This allows changing the style via style sheets rather than code making style sheets more useful. It also adds a button containing a stylable SVG widget and the same with a tool tip. The latter should be refactored to work with any class and remove the need for a subclass.
replaced some references to the old icon button. There are still some uses of the old icon button still to replace.
ALinkCard replaces QLinkCard. They are functionally the same but the new class uses the stylable svg widget.
The new class can contain any widget. This removes the need for custom classes for the widgets inside the draggable container. The new class also supports live rearranging to make it clearer where the dragged widget will end up.
gentlegiantJGC
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the SVG widget and button to allow styling via style sheets rather than code.
This will allow more flexibility to custom styles.
Depreciated QSvgIcon and both QIconButton classes.
Refactored and improved QDragContainer.
ADragContainer now uses the styleable svg button to make styling easier.
Improved drag behaviour. The widgets rearrange as you a dragging making the outcome more obvious.