Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Disallow blue Spotlight and make purple the default #1798

Merged
merged 8 commits into from
Dec 20, 2024

Conversation

VincentSmedinga
Copy link
Contributor

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

This removes the blue option for the colour of a Spotlight.

Why

We don’t want the appearance of Spotlight to interfere with that of Footer.

How

  • Changed the default to purple.
  • Applied the default to the main component class.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

@github-actions github-actions bot temporarily deployed to demo-DES-1113-remove-blue-spotlight-option December 20, 2024 11:16 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1113-remove-blue-spotlight-option December 20, 2024 11:19 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1113-remove-blue-spotlight-option December 20, 2024 11:22 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1113-remove-blue-spotlight-option December 20, 2024 11:24 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1113-remove-blue-spotlight-option December 20, 2024 11:27 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-1113-remove-blue-spotlight-option December 20, 2024 11:29 Destroyed
@alimpens alimpens merged commit 8d1c266 into develop Dec 20, 2024
6 checks passed
@alimpens alimpens deleted the feat/DES-1113-remove-blue-spotlight-option branch December 20, 2024 11:33
@github-actions github-actions bot mentioned this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants