feat!: Make API for icon in button friendlier #1700

VincentSmedinga · 2024-10-25T11:22:45Z

Although the iconPosition enum is a bit more robust, we think an API with iconBefore and iconOnly booleans is friendlier.

This reverts commit 0830fd9.

VincentSmedinga added 6 commits October 25, 2024 12:14

Change iconPosition="only" to hideLabel

847a98f

Change iconPosition="start" to iconBefore

5d666bc

Match tested icon with the documented one

c5d5a0c

Change hideLabel to iconOnly

14e77ab

Fix icon before story name

be0a106

List icons that can be used without a label

0830fd9

VincentSmedinga requested a review from alimpens October 25, 2024 11:22

Improve tests

259d8b2

github-actions bot temporarily deployed to demo-DES-859-button-icon-api October 25, 2024 11:29 Destroyed

Make rendering conditionals more explicit

e4185f0

github-actions bot temporarily deployed to demo-DES-859-button-icon-api October 25, 2024 11:47 Destroyed

Fix import

d93c74e

github-actions bot temporarily deployed to demo-DES-859-button-icon-api October 25, 2024 11:49 Destroyed

Revert "List icons that can be used without a label"

1063da4

This reverts commit 0830fd9.

github-actions bot temporarily deployed to demo-DES-859-button-icon-api October 25, 2024 11:52 Destroyed

Improve the control rendered for iconBefore

a3fcaaf

github-actions bot temporarily deployed to demo-DES-859-button-icon-api October 25, 2024 11:55 Destroyed

Improve the order in which controls get rendered

1440c1f

github-actions bot temporarily deployed to demo-DES-859-button-icon-api October 25, 2024 11:57 Destroyed

Prevent iconBefore and iconOnly from being used together

520b4c4

github-actions bot temporarily deployed to demo-DES-859-button-icon-api October 25, 2024 12:14 Destroyed

Convert function to switch

91cc77f

github-actions bot temporarily deployed to demo-DES-859-button-icon-api October 25, 2024 12:21 Destroyed

Add extra card to prevent issue when combining booleans

96c876e

github-actions bot temporarily deployed to demo-DES-859-button-icon-api October 25, 2024 12:34 Destroyed

Also check for 'icon'

44849cb

github-actions bot temporarily deployed to demo-DES-859-button-icon-api October 25, 2024 12:40 Destroyed

alimpens approved these changes Oct 25, 2024

View reviewed changes

alimpens merged commit 33c4c0e into develop Oct 25, 2024
6 checks passed

alimpens deleted the feature/DES-859-button-icon-api branch October 25, 2024 12:47

github-actions bot mentioned this pull request Oct 25, 2024

chore: release main #1701

Merged

Provide feedback