Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Support various column widths for Description List #1697

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

VincentSmedinga
Copy link
Contributor

Describe the pull request

What

  • Adds an option to change the width of the column containing the term
  • Changes the default behaviour to make the terms fit naturally
  • Widens the gap between terms and columns; they were too close together
  • Fixes toggling ‘inverse color’ for the ‘rich content’ example

Why

  • We received a request to support a different size than the one we offered
  • Letting the size of content inform layout, like we now do, is often nicer

How

  • Added a termWidth prop with three options sm, md, and lg.
  • If the prop is undefined, the default behaviour applies
  • Replaced the gap token with column-gap (breaking change) and started using row-gap

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

@github-actions github-actions bot temporarily deployed to demo-DES-999-description-list-column-widths October 24, 2024 11:01 Destroyed
@alimpens alimpens merged commit 5a98c07 into develop Oct 25, 2024
6 checks passed
@alimpens alimpens deleted the feature/DES-999-description-list-column-widths branch October 25, 2024 09:19
@github-actions github-actions bot mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants