-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Make terms bold instead of descriptions in Description List #1693
Merged
alimpens
merged 11 commits into
develop
from
feature/DES-993-description-list-font-weights
Oct 24, 2024
Merged
feat!: Make terms bold instead of descriptions in Description List #1693
alimpens
merged 11 commits into
develop
from
feature/DES-993-description-list-font-weights
Oct 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubenSibon
previously approved these changes
Oct 21, 2024
github-actions
bot
temporarily deployed
to
demo-DES-993-description-list-font-weights
October 21, 2024 15:42
Destroyed
RubenSibon
previously approved these changes
Oct 22, 2024
alimpens
reviewed
Oct 23, 2024
packages/css/src/components/description-list/description-list.scss
Outdated
Show resolved
Hide resolved
storybook/src/components/DescriptionList/DescriptionList.stories.tsx
Outdated
Show resolved
Hide resolved
storybook/src/components/DescriptionList/DescriptionList.stories.tsx
Outdated
Show resolved
Hide resolved
github-actions
bot
temporarily deployed
to
demo-DES-993-description-list-font-weights
October 23, 2024 18:29
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-993-description-list-font-weights
October 23, 2024 18:32
Destroyed
alimpens
approved these changes
Oct 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
Following a request from our community, We’ve revised our earlier decision to display the descriptions of a Description List with bold text. Instead, we want the terms to be bold.
Why
Regular text is easier to read, especially if it is long as in form summaries. Making terms bold matches the header in forms. All communities in NLDS use bold for the terms, not the descriptions.
How
<dd>
and it does not clash with<details>
.Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes
DescriptionList.Details
toDescriptionList.Description
and thedetails
tokens and classes. Let’s do this in a separate PR.