feat!: Remove unnecessary Dialog wrapper #1591
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
It removes an unnecessary wrapper in Dialog. It also updates some tests.
Why
It simplifies the Dialog component and groups all sizing CSS rules in the same class.
How
By deleting the wrapper and moving all CSS rules to the root class.
Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes
Some things I ran into while doing this work, maybe we should look into them in a separate ticket:
min-block
andmin-inline
size as well, like Utrecht? Maybe we don't want it to shrink beyond a certain point? This is especially an issue for longer body content, that can become so small it's invisible.