Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Remove unnecessary Dialog wrapper #1591

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

alimpens
Copy link
Contributor

@alimpens alimpens commented Sep 18, 2024

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

It removes an unnecessary wrapper in Dialog. It also updates some tests.

Why

It simplifies the Dialog component and groups all sizing CSS rules in the same class.

How

By deleting the wrapper and moving all CSS rules to the root class.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

Some things I ran into while doing this work, maybe we should look into them in a separate ticket:

  • Should we set a min-block and min-inline size as well, like Utrecht? Maybe we don't want it to shrink beyond a certain point? This is especially an issue for longer body content, that can become so small it's invisible.
  • What color should the backdrop be? It's currently a hex value, but what is it based on? Is it a brand color with lower opacity?
  • WAI-ARIA recommends returning the focus to the button that opens the dialog on close. I think we should document that.

@github-actions github-actions bot temporarily deployed to demo-DES-960-remove-dialog-wrapper September 18, 2024 10:49 Destroyed
@VincentSmedinga VincentSmedinga merged commit 450b0c3 into develop Sep 18, 2024
6 checks passed
@VincentSmedinga VincentSmedinga deleted the refactor/DES-960-remove-dialog-wrapper branch September 18, 2024 13:47
@github-actions github-actions bot mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants