feat: Add documention for Gap and Margin utility classes #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentSmedinga
commented
Jul 19, 2024
VincentSmedinga
force-pushed
the
feature/DES-847-utility-class-docs
branch
from
a5c1cea to
9ff747f
Compare
github-actions
bot
temporarily deployed
to
demo-DES-847-utility-class-docs
github-actions
bot
temporarily deployed
to
demo-DES-847-utility-class-docs
github-actions
bot
temporarily deployed
to
demo-DES-847-utility-class-docs
VincentSmedinga
changed the title
alimpens
reviewed
Jul 23, 2024
Importing from source brings the types along, which helps populate the Args Table in Storybook.
github-actions
bot
temporarily deployed
to
demo-DES-847-utility-class-docs
github-actions
bot
temporarily deployed
to
demo-DES-847-utility-class-docs
github-actions
bot
temporarily deployed
to
demo-DES-847-utility-class-docs
alimpens
reviewed
Jul 24, 2024
github-actions
bot
temporarily deployed
to
demo-DES-847-utility-class-docs
github-actions
bot
temporarily deployed
to
demo-DES-847-utility-class-docs
alimpens
reviewed
Jul 24, 2024
github-actions
bot
temporarily deployed
to
demo-DES-847-utility-class-docs
github-actions
bot
temporarily deployed
to
demo-DES-847-utility-class-docs
Enables Storybook to better render the prop values.
github-actions
bot
temporarily deployed
to
demo-DES-847-utility-class-docs
alimpens
reviewed
Jul 24, 2024
Co-authored-by: Aram <[email protected]>
github-actions
bot
temporarily deployed
to
demo-DES-847-utility-class-docs
github-actions
bot
temporarily deployed
to
demo-DES-847-utility-class-docs
github-actions
bot
temporarily deployed
to
demo-DES-847-utility-class-docs
alimpens
reviewed
Jul 24, 2024
Co-authored-by: Aram <[email protected]>
github-actions
bot
temporarily deployed
to
demo-DES-847-utility-class-docs
github-actions
bot
temporarily deployed
to
demo-DES-847-utility-class-docs
alimpens
approved these changes
Jul 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
This documents the Gap and Margin Bottom utility classes.
Why
So that people know when and how to use them – or even that they exist.
How
It follows the approach of the recently added Visually Hidden docs.
I needed to restore the
mdvalue inams-sizesagain, because these gap and margin utilities do need a class name for this size, so I updated theRowandColumnstylesheets to skip this value.By the way, I think we should mark (non-trivial) documentation updates as features from now on. Documentation on how to use things is an important part of our design system and they deserve a place in the change log.