feat: Let Form Error List add the error count to the document title #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
demo-add-page-title-error-count
…om/Amsterdam/design-system into feature/add-page-title-error-count
github-actions
bot
temporarily deployed
to
demo-add-page-title-error-count
RubenSibon
reviewed
Jun 28, 2024
packages/react/src/FormErrorList/useAddErrorCountToPageTitle.tsx
Outdated
Show resolved
Hide resolved
packages/react/src/FormErrorList/useAddErrorCountToPageTitle.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Vincent Smedinga <[email protected]>
github-actions
bot
temporarily deployed
to
demo-add-page-title-error-count
github-actions
bot
temporarily deployed
to
demo-add-page-title-error-count
github-actions
bot
temporarily deployed
to
demo-add-page-title-error-count
…om/Amsterdam/design-system into feature/add-page-title-error-count
github-actions
bot
temporarily deployed
to
demo-add-page-title-error-count
VincentSmedinga
changed the title
github-actions
bot
temporarily deployed
to
demo-add-page-title-error-count
github-actions
bot
temporarily deployed
to
demo-add-page-title-error-count
github-actions
bot
temporarily deployed
to
demo-add-page-title-error-count
github-actions
bot
temporarily deployed
to
demo-add-page-title-error-count
VincentSmedinga
approved these changes
Jul 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the GOV.UK validation pattern is showing the error count in the document title. Seeing as Form Error List already gets the list of errors, it made sense to add this functionality here.
On the GOV.UK Design System discussion boards someone mentioned that people often forget to implement this when they have to do it manually, so I think it makes sense to incorporate it in a component.