Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Rename title props for Alert, Header and Dialog and require it for Dialog #1251

Merged
merged 15 commits into from
Jun 7, 2024
Merged

feat!: Rename title props for Alert, Header and Dialog and require it for Dialog #1251

merged 15 commits into from
Jun 7, 2024

Conversation

dlnr
Copy link
Contributor

@dlnr dlnr commented Jun 5, 2024 •
edited by VincentSmedinga
Loading

We’ve renamed the title prop of these components. This increases consistency: they render a Heading component. Updated the docs as well.

  • Alert: title -> heading (optional)
  • Dialog: title -> heading (required)
  • Header: title -> appName

For implementers: note that title is a global HTML attribute, so this change will not highlight instances of this property as TypeScript errors.

@dlnr dlnr self-assigned this Jun 5, 2024
@dlnr dlnr requested a review from VincentSmedinga June 5, 2024 08:08
@VincentSmedinga VincentSmedinga changed the title feat: Rename title props feat!: Rename title props for Alert, Header and Dialog and require it for Dialog Jun 5, 2024
@github-actions github-actions bot temporarily deployed to demo-DES-782-heading-prop June 5, 2024 09:41 Destroyed
@VincentSmedinga VincentSmedinga requested a review from alimpens June 5, 2024 09:44
@github-actions github-actions bot temporarily deployed to demo-DES-782-heading-prop June 5, 2024 10:00 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-782-heading-prop June 5, 2024 10:04 Destroyed
VincentSmedinga
VincentSmedinga previously approved these changes Jun 5, 2024
View reviewed changes
@github-actions github-actions bot temporarily deployed to demo-DES-782-heading-prop June 5, 2024 10:06 Destroyed
alimpens
alimpens reviewed Jun 5, 2024
View reviewed changes
packages/react/src/Alert/Alert.test.tsx Outdated Show resolved Hide resolved
packages/react/src/Dialog/Dialog.test.tsx Outdated Show resolved Hide resolved
storybook/src/components/Header/Header.docs.mdx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-DES-782-heading-prop June 6, 2024 13:46 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-782-heading-prop June 7, 2024 08:54 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-782-heading-prop June 7, 2024 09:03 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-782-heading-prop June 7, 2024 09:15 Destroyed
VincentSmedinga
VincentSmedinga previously approved these changes Jun 7, 2024
View reviewed changes
@github-actions github-actions bot temporarily deployed to demo-DES-782-heading-prop June 7, 2024 09:19 Destroyed
@VincentSmedinga VincentSmedinga merged commit bbec4de into develop Jun 7, 2024
4 checks passed
@VincentSmedinga VincentSmedinga deleted the feature/DES-782-heading-prop branch June 7, 2024 09:22
@github-actions github-actions bot mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimpens alimpens alimpens left review comments

@VincentSmedinga VincentSmedinga VincentSmedinga approved these changes

Assignees

@dlnr dlnr

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlnr @VincentSmedinga @alimpens