Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix issues with inputs on iOS #1241

Merged
merged 2 commits into from
May 29, 2024
Merged

fix: Fix issues with inputs on iOS #1241

merged 2 commits into from
May 29, 2024

Conversation

alimpens
Copy link
Contributor

No description provided.

RubenSibon
RubenSibon approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@RubenSibon RubenSibon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I assume this has been thoroughly tested on all supported devices and browsers.

packages/css/src/components/select/select.scss Show resolved Hide resolved
@alimpens
Copy link
Contributor Author

LGTM, I assume this has been thoroughly tested on all supported devices and browsers.

Thanks! I tested it on Chrome, Firefox and Edge on Windows, Chrome on Android and Safari 15.2, 15.6 and 16.6 on iOS.

@github-actions github-actions bot temporarily deployed to demo-DES-735-inputs-on-ios-bugs May 29, 2024 11:58 Destroyed
@VincentSmedinga VincentSmedinga merged commit dcd2f6e into develop May 29, 2024
4 checks passed
@VincentSmedinga VincentSmedinga deleted the fix/DES-735-inputs-on-ios-bugs branch May 29, 2024 12:01
@github-actions github-actions bot mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RubenSibon RubenSibon RubenSibon approved these changes

@VincentSmedinga VincentSmedinga VincentSmedinga approved these changes

@dlnr dlnr Awaiting requested review from dlnr

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alimpens @VincentSmedinga @RubenSibon