feat: Add examples of entire pages to Storybook #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commits: [8fb07f04c] WIP
VincentSmedinga
changed the title
And implement it standalone in the example article page.
alimpens
reviewed
Jun 19, 2024
alimpens
approved these changes
Jun 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For your consideration, some example page patterns. This is a very quick and developer friendly way to create full pages in Storybook, you can reuse stories (see Article story) or completely static (Homepage story is a copy of prototypes).
There are added benefits like a11y tests for the full page, interactions tests for forms, quick theme switching, viewports etc.
Also, we don't have to maintain another app like prototypes. We should do a prototypes pages more like a started kit because developers will use it as such.
I've not included the pages in a Canvas block but instead created an example codeblock with some pseudo page layout code. The idea is to elaborate on page structure and leave the pages to fullscreen examples.