feat: Select component #1151
Merged
feat: Select component #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/DES-662-Select
…into feature/DES-662-Select
…into feature/DES-662-Select
dlnr
commented
Apr 5, 2024
alimpens
reviewed
Apr 10, 2024
alimpens
reviewed
Apr 15, 2024
dlnr
requested review from
alimpens and
VincentSmedinga
and removed request for
alimpens
alimpens
reviewed
Apr 17, 2024
alimpens
previously approved these changes
Apr 19, 2024
alimpens
reviewed
Apr 19, 2024
alimpens
approved these changes
Apr 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed the combobox MVP will have a native dropdown. I've created child components to align without our approach in other components and align with NLDS.