Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add border tokens and use rems for widths #1147

Merged
merged 11 commits into from
Mar 29, 2024

Conversation

alimpens
Copy link
Contributor

@alimpens alimpens commented Mar 27, 2024

  • I moved the border tokens from common to brand, they make more sense there imo
  • Negative values don't seem to work with these tokens, so Tabs button still has a negative hardcoded value
  • In Table, the border is set on the cell, because a border on the row doesn't work with the default border-collapse: separate. border-collapse: collapse caused other issues I think, but I can't quite remember what they were.

@github-actions github-actions bot temporarily deployed to demo-DES-578-border-tokens March 27, 2024 13:10 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-578-border-tokens March 27, 2024 13:17 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-578-border-tokens March 27, 2024 13:19 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-578-border-tokens March 29, 2024 09:11 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-578-border-tokens March 29, 2024 09:53 Destroyed
@VincentSmedinga VincentSmedinga changed the title feat: Add border tokens, set border width in rems feat: Add border tokens and use rems for widths Mar 29, 2024
@VincentSmedinga VincentSmedinga merged commit d91d889 into develop Mar 29, 2024
5 checks passed
@VincentSmedinga VincentSmedinga deleted the feat/DES-578-border-tokens branch March 29, 2024 10:15
@github-actions github-actions bot mentioned this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants