Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add background colour and full-height prop to Screen #1144

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

VincentSmedinga
Copy link
Contributor

The initial value for background-color is transparent. I can imagine either dark mode or an OS or browser theme setting a background colour, but I’d rather be sure it’s white. We can adapt for dark mode later.

Another reason to define it explicitly is that even though a white background may come by default sometimes, it is an explicit part of our design that other components rely on.

We need the 100vh height for applications, e.g. to accommodate the side menu. We also need it to ensure the white background spans from top to bottom.

@github-actions github-actions bot temporarily deployed to demo-make-screen-white March 24, 2024 22:14 Destroyed
@alimpens alimpens merged commit c4621e8 into develop Mar 25, 2024
4 checks passed
@alimpens alimpens deleted the feat/make-screen-white branch March 25, 2024 08:44
@github-actions github-actions bot mentioned this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants