feat: Add background colour and full-height prop to Screen #1144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial value for
background-color
istransparent
. I can imagine either dark mode or an OS or browser theme setting a background colour, but I’d rather be sure it’s white. We can adapt for dark mode later.Another reason to define it explicitly is that even though a white background may come by default sometimes, it is an explicit part of our design that other components rely on.
We need the
100vh
height for applications, e.g. to accommodate the side menu. We also need it to ensure the white background spans from top to bottom.