feat!: Allow setting a background colour on Tabs List #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more intentful and may be easier to animate.
VincentSmedinga
changed the title
alimpens
reviewed
Mar 25, 2024
github-actions
bot
temporarily deployed
to
demo-tabs-background-colours
github-actions
bot
temporarily deployed
to
demo-tabs-background-colours
github-actions
bot
temporarily deployed
to
demo-tabs-background-colours
github-actions
bot
temporarily deployed
to
demo-tabs-background-colours
github-actions
bot
temporarily deployed
to
demo-tabs-background-colours
github-actions
bot
temporarily deployed
to
demo-tabs-background-colours
alimpens
reviewed
Mar 27, 2024
Co-authored-by: Aram <[email protected]>
github-actions
bot
temporarily deployed
to
demo-tabs-background-colours
alimpens
reviewed
Mar 29, 2024
Co-authored-by: Aram <[email protected]>
github-actions
bot
temporarily deployed
to
demo-tabs-background-colours
# Conflicts: # proprietary/tokens/src/components/ams/tabs.tokens.json
github-actions
bot
temporarily deployed
to
demo-tabs-background-colours
alimpens
approved these changes
Mar 29, 2024
VincentSmedinga
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tabs list may not always have the same background colour as the parent container. Our applications have a grey background, so we need something to make the tabs list's background colour white. An example here.
Additionally, I think setting the inactive button background to white is more intentional than making it transparent, and it may be easier to animate the colour later.