feat: Add document-level classes and guidelines #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentSmedinga
commented
Mar 20, 2024
VincentSmedinga
commented
Mar 20, 2024
# Conflicts: # packages/css/src/components/index.scss
github-actions
bot
temporarily deployed
to
demo-DES-559-document-classes-and-docs
alimpens
reviewed
Mar 20, 2024
Co-authored-by: Aram <[email protected]>
github-actions
bot
temporarily deployed
to
demo-DES-559-document-classes-and-docs
github-actions
bot
temporarily deployed
to
demo-DES-559-document-classes-and-docs
alimpens
reviewed
Mar 25, 2024
github-actions
bot
temporarily deployed
to
demo-DES-559-document-classes-and-docs
github-actions
bot
temporarily deployed
to
demo-DES-559-document-classes-and-docs
# Conflicts: # packages/css/src/components/screen/screen.scss
github-actions
bot
temporarily deployed
to
demo-DES-559-document-classes-and-docs
alimpens
reviewed
Mar 26, 2024
Co-authored-by: Aram <[email protected]>
github-actions
bot
temporarily deployed
to
demo-DES-559-document-classes-and-docs
github-actions
bot
temporarily deployed
to
demo-DES-559-document-classes-and-docs
github-actions
bot
temporarily deployed
to
demo-DES-559-document-classes-and-docs
alimpens
reviewed
Mar 26, 2024
Co-authored-by: Aram <[email protected]>
github-actions
bot
temporarily deployed
to
demo-DES-559-document-classes-and-docs
alimpens
approved these changes
Mar 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our prototyping environment taught us that we need some base styling at the document level to ensure a correct context for our CSS and layout.
This adds a class to remove the default browser margin from the
bodyelementand sets 100% height and a white background colour (which can later depend on light and dark mode).It also uses our extra bold font weight for strongly emphasised text, scoped to our theme class.Our typography system expects
1remto be16px; we explain that the root font size must not be overridden.