Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use VisuallyHidden instead of aria-label for screen reader only text in Top task link #1115

Merged
merged 6 commits into from
Mar 8, 2024

Conversation

alimpens
Copy link
Contributor

@alimpens alimpens commented Mar 7, 2024

No description provided.

@alimpens alimpens requested review from VincentSmedinga and dlnr March 7, 2024 16:30
@github-actions github-actions bot temporarily deployed to demo-use-visually-hidden-not-aria March 7, 2024 16:49 Destroyed
@github-actions github-actions bot temporarily deployed to demo-use-visually-hidden-not-aria March 8, 2024 10:36 Destroyed
@github-actions github-actions bot temporarily deployed to demo-use-visually-hidden-not-aria March 8, 2024 10:50 Destroyed
@github-actions github-actions bot temporarily deployed to demo-use-visually-hidden-not-aria March 8, 2024 11:04 Destroyed
VincentSmedinga
VincentSmedinga previously approved these changes Mar 8, 2024
@github-actions github-actions bot temporarily deployed to demo-use-visually-hidden-not-aria March 8, 2024 11:11 Destroyed
@alimpens alimpens merged commit 4281fa1 into develop Mar 8, 2024
4 checks passed
@alimpens alimpens deleted the fix/use-visually-hidden-not-aria branch March 8, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants