-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Use spacing tokens in Grid component #1089
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
demo-DES-612-use-gap-in-grid
February 21, 2024 16:18
Destroyed
This reverts commit 918fe7f.
github-actions
bot
temporarily deployed
to
demo-DES-612-use-gap-in-grid
February 21, 2024 16:24
Destroyed
2 tasks
github-actions
bot
temporarily deployed
to
demo-DES-612-use-gap-in-grid
February 23, 2024 12:13
Destroyed
alimpens
reviewed
Feb 23, 2024
proprietary/tokens/src/components/amsterdam/grid.compact.tokens.json
Outdated
Show resolved
Hide resolved
dlnr
reviewed
Feb 23, 2024
# Conflicts: # storybook/src/components/Grid/Grid.docs.mdx
github-actions
bot
temporarily deployed
to
demo-DES-612-use-gap-in-grid
February 27, 2024 11:28
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-612-use-gap-in-grid
February 27, 2024 13:37
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-612-use-gap-in-grid
February 27, 2024 21:18
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-612-use-gap-in-grid
February 27, 2024 21:25
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-612-use-gap-in-grid
February 28, 2024 08:54
Destroyed
alimpens
reviewed
Feb 28, 2024
github-actions
bot
temporarily deployed
to
demo-DES-612-use-gap-in-grid
February 28, 2024 10:17
Destroyed
github-actions
bot
temporarily deployed
to
demo-DES-612-use-gap-in-grid
February 28, 2024 10:19
Destroyed
alimpens
reviewed
Feb 28, 2024
github-actions
bot
temporarily deployed
to
demo-DES-612-use-gap-in-grid
February 28, 2024 12:50
Destroyed
alimpens
approved these changes
Feb 28, 2024
dlnr
approved these changes
Feb 29, 2024
github-actions
bot
temporarily deployed
to
demo-DES-612-use-gap-in-grid
February 29, 2024 08:44
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the Grid component use the new Space tokens, which were, in their turn, based on the Grid gap token.
Uses Sass to generate classes for gap and padding. I intended to use shorter, local variable names, but prefixing withamsterdam
is required.Introduces a.amsterdam-grid--gap--medium
class that wasn’t previously there as the base component includes the medium gap class.The change is breaking because:
amsterdam-grid-gap
token is nowamsterdam-grid-gap-md
large
vertical padding of the grid is now 1.5 (instead of 2) times as wide as the regular gap width to match the space token naming