Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Column component and Gap and Margin utilities for vertical spacing #1083

Merged
merged 45 commits into from
Feb 21, 2024
Merged

feat: Add Column component and Gap and Margin utilities for vertical spacing #1083

merged 45 commits into from
Feb 21, 2024

Conversation

VincentSmedinga
Copy link
Contributor

No description provided.

@VincentSmedinga VincentSmedinga marked this pull request as draft February 14, 2024 22:24
@github-actions github-actions bot temporarily deployed to demo-DES-612-vertical-spacing February 15, 2024 11:50 Destroyed
@VincentSmedinga VincentSmedinga force-pushed the feature/DES-612-vertical-spacing branch from ae983a0 to dffa340 Compare February 15, 2024 12:24
@github-actions github-actions bot temporarily deployed to demo-DES-612-vertical-spacing February 15, 2024 12:24 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-612-vertical-spacing February 16, 2024 09:49 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-612-vertical-spacing February 16, 2024 10:30 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-612-vertical-spacing February 16, 2024 11:03 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-612-vertical-spacing February 16, 2024 11:06 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-612-vertical-spacing February 16, 2024 11:09 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-612-vertical-spacing February 16, 2024 11:12 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-612-vertical-spacing February 16, 2024 20:04 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-612-vertical-spacing February 18, 2024 13:31 Destroyed
dlnr
dlnr reviewed Feb 19, 2024
View reviewed changes
Copy link
Contributor

@dlnr dlnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have probably used just one file (spacing.tokens) and not add a util but this is fine. I'll probably have more feedback when using this in a layout.

proprietary/tokens/src/brand/amsterdam/space.tokens.json Outdated Show resolved Hide resolved
storybook/storybook-docs/src/spacing.stories.mdx Outdated Show resolved Hide resolved
proprietary/tokens/src/common/amsterdam/margin.tokens.json Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-DES-612-vertical-spacing February 19, 2024 18:26 Destroyed
@VincentSmedinga
Merge branch 'develop' into feature/DES-612-vertical-spacing
d15b36e 
# Conflicts:
#	packages/css/src/components/index.scss
#	packages/react/src/index.ts
@github-actions github-actions bot temporarily deployed to demo-DES-612-vertical-spacing February 19, 2024 23:45 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-612-vertical-spacing February 20, 2024 10:39 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-612-vertical-spacing February 20, 2024 10:41 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-612-vertical-spacing February 20, 2024 11:55 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-612-vertical-spacing February 21, 2024 13:04 Destroyed
@github-actions github-actions bot temporarily deployed to demo-DES-612-vertical-spacing February 21, 2024 13:34 Destroyed
@VincentSmedinga VincentSmedinga merged commit d092cb3 into develop Feb 21, 2024
4 checks passed
@VincentSmedinga VincentSmedinga deleted the feature/DES-612-vertical-spacing branch February 21, 2024 13:49
@github-actions github-actions bot mentioned this pull request Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlnr dlnr dlnr left review comments

@alimpens alimpens alimpens approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VincentSmedinga @dlnr @alimpens