From d4da3f73e34f3c8d590b31cf7a74ff0f94774f9e Mon Sep 17 00:00:00 2001 From: Aram <37216945+alimpens@users.noreply.github.com> Date: Mon, 26 Aug 2024 13:16:22 +0200 Subject: [PATCH] chore: Make Text Input and Text Area uncontrolled in stories (#1533) Co-authored-by: Vincent Smedinga --- .../OrderedList/OrderedList.stories.tsx | 3 --- .../src/components/TextArea/TextArea.stories.tsx | 8 ++++---- .../components/TextInput/TextInput.stories.tsx | 16 ++++++++-------- 3 files changed, 12 insertions(+), 15 deletions(-) diff --git a/storybook/src/components/OrderedList/OrderedList.stories.tsx b/storybook/src/components/OrderedList/OrderedList.stories.tsx index 7cae91e187..e8befbcc2b 100644 --- a/storybook/src/components/OrderedList/OrderedList.stories.tsx +++ b/storybook/src/components/OrderedList/OrderedList.stories.tsx @@ -27,9 +27,6 @@ const meta = { reversed: { control: 'boolean', description: 'Numbers the items from the highest value down.', - table: { - defaultValue: { summary: 'false' }, - }, }, start: { control: 'number', diff --git a/storybook/src/components/TextArea/TextArea.stories.tsx b/storybook/src/components/TextArea/TextArea.stories.tsx index 5d64d03913..7fc3e89f1f 100644 --- a/storybook/src/components/TextArea/TextArea.stories.tsx +++ b/storybook/src/components/TextArea/TextArea.stories.tsx @@ -13,7 +13,7 @@ const meta = { title: 'Components/Forms/Text Area', component: TextArea, args: { - value: paragraph, + defaultValue: paragraph, disabled: false, invalid: false, }, @@ -24,6 +24,9 @@ const meta = { }, description: 'The width, expressed in the average number of characters.', }, + defaultValue: { + table: { disable: true }, + }, disabled: { description: 'Prevents interaction. Avoid if possible.', }, @@ -40,9 +43,6 @@ const meta = { }, description: 'The number of lines to show', }, - value: { - description: 'The value of the field.', - }, }, } satisfies Meta diff --git a/storybook/src/components/TextInput/TextInput.stories.tsx b/storybook/src/components/TextInput/TextInput.stories.tsx index 925978d717..d623083835 100644 --- a/storybook/src/components/TextInput/TextInput.stories.tsx +++ b/storybook/src/components/TextInput/TextInput.stories.tsx @@ -14,15 +14,15 @@ const meta = { invalid: false, }, argTypes: { + defaultValue: { + table: { disable: true }, + }, disabled: { description: 'Prevents interaction. Avoid if possible.', }, invalid: { description: 'Whether the value fails a validation rule.', }, - value: { - description: 'The value of the field.', - }, }, } satisfies Meta @@ -34,22 +34,22 @@ export const Default: Story = {} export const EmailAddress: Story = { args: { + defaultValue: 'designsystem@amsterdam.nl', type: 'email', - value: 'designsystem@amsterdam.nl', }, } export const WebAddress: Story = { args: { + defaultValue: 'https://designsystem.amsterdam/', type: 'url', - value: 'https://designsystem.amsterdam/', }, } export const PhoneNumber: Story = { args: { + defaultValue: '14020', type: 'tel', - value: '14020', }, } @@ -61,14 +61,14 @@ export const Placeholder: Story = { export const Invalid: Story = { args: { + defaultValue: 'Invalid value', invalid: true, - value: 'Invalid value', }, } export const Disabled: Story = { args: { + defaultValue: 'Disabled input', disabled: true, - value: 'Disabled input', }, }