From 5593916904db612f4dfa1c5d02c88add35d0103a Mon Sep 17 00:00:00 2001 From: Aram <37216945+alimpens@users.noreply.github.com> Date: Fri, 21 Jun 2024 12:29:20 +0200 Subject: [PATCH 1/3] fix: Fix FieldSet float issue (#1268) Co-authored-by: Vincent Smedinga --- packages/css/src/components/field-set/field-set.scss | 4 ++++ storybook/src/components/FieldSet/FieldSet.stories.tsx | 6 +++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/css/src/components/field-set/field-set.scss b/packages/css/src/components/field-set/field-set.scss index c5dbd83589..9b4a690462 100644 --- a/packages/css/src/components/field-set/field-set.scss +++ b/packages/css/src/components/field-set/field-set.scss @@ -28,6 +28,10 @@ float: inline-start; // [1] inline-size: 100%; // [1] padding-inline: 0; + + + * { + clear: both; // Reset the applied float for the legend’s first sibling + } } // [1] This combination allows the fieldset border to go around the legend, instead of through it. diff --git a/storybook/src/components/FieldSet/FieldSet.stories.tsx b/storybook/src/components/FieldSet/FieldSet.stories.tsx index 1aed9b47b9..ca444a3ed8 100644 --- a/storybook/src/components/FieldSet/FieldSet.stories.tsx +++ b/storybook/src/components/FieldSet/FieldSet.stories.tsx @@ -38,7 +38,7 @@ type Story = StoryObj export const Default: Story = { render: (args) => (
- + @@ -161,7 +161,7 @@ export const CheckboxGroup: Story = { }, render: (args) => (
- + Horecabedrijf @@ -187,7 +187,7 @@ export const CheckboxGroup: Story = { // render: (args) => ( //
// {args.invalid && Geef aan waar uw melding over gaat.} -// +// // // Horecabedrijf // From e5f8d5820b4aac7e9ed145e3a3dbfd22480304de Mon Sep 17 00:00:00 2001 From: Niels Roozemond Date: Fri, 21 Jun 2024 14:11:37 +0200 Subject: [PATCH 2/3] feat: Add examples of entire pages to Storybook (#1234) Co-authored-by: Vincent Smedinga --- packages/react/src/PageMenu/PageMenu.test.tsx | 10 +- storybook/config/manager-head.html | 6 +- storybook/config/preview.tsx | 2 + storybook/config/storybook-overrides.css | 4 + .../Breadcrumb/Breadcrumb.stories.tsx | 7 +- .../src/components/Card/Card.stories.tsx | 15 +- .../src/components/Footer/Footer.docs.mdx | 11 +- .../src/components/Footer/Footer.stories.tsx | 198 +++++++++++++----- storybook/src/components/Image/Image.docs.mdx | 1 + .../src/components/Image/Image.stories.tsx | 1 + .../components/Overlap/Overlap.stories.tsx | 5 +- .../components/PageMenu/PageMenu.stories.tsx | 19 +- .../src/components/shared/exampleContent.ts | 59 +++++- storybook/src/pages/Introduction.docs.mdx | 39 ++++ .../pages/amsterdam/article/Article.docs.mdx | 10 + .../amsterdam/article/Article.stories.tsx | 38 ++++ .../src/pages/amsterdam/article/Article.tsx | 45 ++++ .../pages/amsterdam/article/ArticleBody.tsx | 116 ++++++++++ .../amsterdam/article/ArticleBreadcrumb.tsx | 12 ++ .../pages/amsterdam/article/ArticleHeader.tsx | 20 ++ .../src/pages/amsterdam/common/AppHeader.tsx | 13 ++ .../src/pages/amsterdam/home/Home.docs.mdx | 46 ++++ .../src/pages/amsterdam/home/Home.stories.tsx | 30 +++ storybook/src/pages/amsterdam/home/Home.tsx | 29 +++ .../src/pages/amsterdam/home/HomeNews.tsx | 45 ++++ .../pages/amsterdam/home/HomeSpotlight.tsx | 32 +++ .../src/pages/amsterdam/home/HomeTopTasks.tsx | 84 ++++++++ 27 files changed, 808 insertions(+), 89 deletions(-) create mode 100644 storybook/src/pages/Introduction.docs.mdx create mode 100644 storybook/src/pages/amsterdam/article/Article.docs.mdx create mode 100644 storybook/src/pages/amsterdam/article/Article.stories.tsx create mode 100644 storybook/src/pages/amsterdam/article/Article.tsx create mode 100644 storybook/src/pages/amsterdam/article/ArticleBody.tsx create mode 100644 storybook/src/pages/amsterdam/article/ArticleBreadcrumb.tsx create mode 100644 storybook/src/pages/amsterdam/article/ArticleHeader.tsx create mode 100644 storybook/src/pages/amsterdam/common/AppHeader.tsx create mode 100644 storybook/src/pages/amsterdam/home/Home.docs.mdx create mode 100644 storybook/src/pages/amsterdam/home/Home.stories.tsx create mode 100644 storybook/src/pages/amsterdam/home/Home.tsx create mode 100644 storybook/src/pages/amsterdam/home/HomeNews.tsx create mode 100644 storybook/src/pages/amsterdam/home/HomeSpotlight.tsx create mode 100644 storybook/src/pages/amsterdam/home/HomeTopTasks.tsx diff --git a/packages/react/src/PageMenu/PageMenu.test.tsx b/packages/react/src/PageMenu/PageMenu.test.tsx index e87e594afa..ad40927c05 100644 --- a/packages/react/src/PageMenu/PageMenu.test.tsx +++ b/packages/react/src/PageMenu/PageMenu.test.tsx @@ -8,9 +8,11 @@ describe('Page menu', () => { it('renders a page menu with children', () => { const { container } = render( - English + + English + - Inloggen Mijn Amsterdam + Mijn Amsterdam , ) @@ -39,7 +41,9 @@ describe('Page menu', () => { const ref = createRef() const { container } = render( - English + + English + , ) const component = container.querySelector(':only-child') diff --git a/storybook/config/manager-head.html b/storybook/config/manager-head.html index 7f45090a29..c45ed87fff 100644 --- a/storybook/config/manager-head.html +++ b/storybook/config/manager-head.html @@ -1,9 +1,11 @@