Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align behaviour of textual content #727

Open
4 tasks
jonkoops opened this issue Jul 1, 2020 · 2 comments
Open
4 tasks

Align behaviour of textual content #727

jonkoops opened this issue Jul 1, 2020 · 2 comments
Assignees
@jonkoops
Labels
design-system-alignment This issue is meant to align our code to the design system. enhancement New feature or request
Milestone
1.0.0

Comments

@jonkoops
Copy link
Contributor

jonkoops commented Jul 1, 2020 •
edited
Loading

In the design system there is a non-documented distinction of elements such as links, paragraphs, headers, etc. used in the context of an article or 'textual content'.

For example, a link used on an article page has a font-size of 18px, line-height of 22px and when visited is coloured purple. However outside of this context the link should always have a font-size of 16px, a line-height of 20px and does not change colour.

Right now all these elements act as textual content, this will have to be changed so that all components act like they are not in an article by default and only revert to the textual content behaviour when used inside a TextualContentThemeProvider. This change will also mean that we will no longer support the CompactThemeProvider as it will become the default behaviour.

Todo

  • Align with the Design System team about behaviour and proposed solution
  • Align with the developers about behaviour and proposed solution
  • Use CompactThemeProvider styles by default and introduce a TextualContentThemeProvider component for textual content.
  • Remove the CompactThemeProvider
@jonkoops jonkoops added enhancement New feature or request design-system-alignment This issue is meant to align our code to the design system. needs-alignment This issue/PR is needs alignment before being worked on further. labels Jul 1, 2020
@jonkoops jonkoops added this to the 1.0.0 milestone Jul 1, 2020
@jonkoops jonkoops self-assigned this Jul 1, 2020
@jonkoops jonkoops changed the title Align behaviour of textual content and 'application' content Align behaviour of textual content Jul 1, 2020
@chrisvanmook
Copy link
Contributor

Wait for this is resolved https://trello.com/c/jnsiHGpu/351-textual-content-bespreken
We might discard this

@jonkoops
Copy link
Contributor Author

jonkoops commented Sep 1, 2020

The decision has been made to use the font-sizes on the largest media query by default (as specified by the DS)

@jonkoops jonkoops removed the needs-alignment This issue/PR is needs alignment before being worked on further. label Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonkoops jonkoops

Labels
design-system-alignment This issue is meant to align our code to the design system. enhancement New feature or request
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@jonkoops @chrisvanmook