Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Players for API endpoint #168

Open
atifsiddiqui10 opened this issue Dec 14, 2024 · 1 comment
Open

Missing Players for API endpoint #168

atifsiddiqui10 opened this issue Dec 14, 2024 · 1 comment

Comments

@atifsiddiqui10
Copy link

HI,

I was trying to name match some MLS (Inter Miami) players by playerId's and noticed that the players endpoint doesn't have all the players. For the 2024 season I am only getting 6 players from Inter Miami. Would really appreciate a fix or explanation on this. Working on a cool project using the data from the api.

Thank you

@tyler-richardett
Copy link
Member

Hey, thanks for reaching out. Could you drop a sample request here to help debug?

My guess: If you're hitting the endpoint directly, each is paginated and returns a maximum of 100 records. As such, you can pass offset and limit parameters to walk through each results set (e.g., https://app.americansocceranalysis.com/api/v1/mls/players?offset=100&limit=100). Depending on which programming language you're using, you may also want to leverage the itscalledsoccer (Python, R) library, which handles this pagination implicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants