Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find sub for series with year in name #14

Open
thesupbiker opened this issue May 8, 2018 · 11 comments
Open

Cannot find sub for series with year in name #14

thesupbiker opened this issue May 8, 2018 · 11 comments

Comments

@thesupbiker
Copy link

Some series like Hawaii Five-0 2010 and MacGyver 2016 have year in name and as result the plugin is treating them as film since xbmc.getCleanMovieTitle removes the S11E32 part and returns the year.

@Grossdm
Copy link

Grossdm commented Jun 25, 2018

@thesupbiker,

My suggestion may be disrespectful to @Amelandbor - if so, please excuse this post.

I found a different addic7ed addon that works well for me (YMMV, etc.).

The dev is @romanvm and he has a regular GitHub page, but to get the zip file to install his repo in Kodi, you need this URL:
http://romanvm.github.io/kodi_repo

He has a link for the repo zip file on that page only, AFAIK.

Good luck!

@romanvm
Copy link

romanvm commented Jun 26, 2018

but to get the zip file to install his repo in Kodi, you need this URL:

This is actually not true. Installable ZIPs are available on "Releases" tab of the repo: https://github.com/romanvm/service.addic7ed/releases

@Grossdm
Copy link

Grossdm commented Jun 27, 2018

This is actually not true. Installable ZIPs are available on "Releases" tab of the repo: https://github.com/romanvm/service.addic7ed/releases

Thank you for suggesting this option, @romanvm.
I wanted to help @thesupbiker get your repository setup within Kodi. This would notify of any update to your addic7ed addon, as well as show your other addons. 👍

May I ask why you have your Kodi repo setup with githib.io instead of the more common direct github.com?
I think it would be easier for users to add your repo from github.com, but you may have reasons for your choice.

Thank you for your helpful addon and quick response!

Doug®

@romanvm
Copy link

romanvm commented Jun 27, 2018

github.io is GitHub Pages' domain where my repo is hosted. And what's the difference? An average user won't see the repo URL anyway.

@thesupbiker thesupbiker changed the title Cannon find sub for series with year in name Cannot find sub for series with year in name Jun 27, 2018
@thesupbiker
Copy link
Author

thank you very much @Grossdm for suggesting the alternative of @romanvm, I will try it :)

@Grossdm
Copy link

Grossdm commented Jun 28, 2018

@romanvm, I think that most Kodi users are accustomed to adding a URL source in Kodi's File manager as the method to add a new repo - by then using Install from zip file in the Add-on browser.

My understanding is that you prefer users to download the repo zip file using a web browser, which is certainly your prerogative.

I am curious, though. Would you mind sharing why you decided on this setup for your repo?
:-)

@Grossdm
Copy link

Grossdm commented Jun 28, 2018

You're quite welcome, @thesupbiker!

I'm confident that you will like this addic7ed addon much more than the other one.

Frankly, every aspect of it that I can think of is better or works "more smoothly" - @romanvm really did a good job with this.

@romanvm
Copy link

romanvm commented Jun 28, 2018

I think that most Kodi users are accustomed to adding a URL source in Kodi's File manager as the method to add a new repo

This method is not officially supported (more like a side effect than a feature) and can be removed any time.

@Grossdm
Copy link

Grossdm commented Jun 28, 2018

This method is not officially supported (more like a side effect than a feature) and can be removed any time.

I certainly noticed the Unknown sources option with its pop-up giving a dire security warning. Two thoughts: looks like CYA considering all the recent legal activity; also it reminded me of the nearly identical option in Android.

Whatever methods are allowed in the future to install addons not from the Official Kodi Repository, users will adapt.
If the XBMC Foundation disallows other repositories, I would expect that one of Kodi's forks would emerge as the leading media center. Surely a number of Kodi developers would leave as well.

I may be thinking about this too much. :-)

@romanvm
Copy link

romanvm commented Jul 4, 2018

There are no plans to remove support of third party repositories at the moment. However, the "official" way is to install a repo addon from ZIP and then install addons from it via Kodi's addon browser.

@Grossdm
Copy link

Grossdm commented Jul 5, 2018

I understand in principal.

However, I still feel that most users (especially those with a purchased media device, e.g. NVidia Shield) may have some difficulty installing a repo from a zip file if the zip must be downloaded outside of Kodi.

On a different matter, I could not upgrade your addon to v. 2.2.1 because of "unmet dependencies" - I still have old versions of Android and hence Kodi is Jarvis.

I tracked it down to the newer xbmc.python version specified in your addon.
I tried v. 2.2.1 with the xbmc.python version bumped down slightly.
Kodi was happy and the addon is running fine so far.

Should I submit a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants