Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Schemas with swagger-parser v1.18.0 #3

Open
AmateurECE opened this issue Nov 8, 2023 · 1 comment
Open

Duplicate Schemas with swagger-parser v1.18.0 #3

AmateurECE opened this issue Nov 8, 2023 · 1 comment
Assignees

Comments

@AmateurECE
Copy link
Owner

Unfortunately, there seems to be a defect in swagger-parser v1.18.0 that causes duplicate schemas to be generated when there are circular references between OpenAPI specification files. This manifests in the output of redfish-generator:

[main] WARN com.twardyece.dmtf.specification.OpenapiSpecification - Duplicate schema AccountService_v1_13_0_MFABypass_1 encountered while parsing AccountService.v1_13_0.yaml
...
[main] WARN com.twardyece.dmtf.specification.OpenapiSpecification - Duplicate schema StorageControllerMetrics_v1_0_0_NVMeSMARTMetrics_1 encountered while parsing StorageControllerMetrics.v1_0_0.yaml

I've opened swagger-api/swagger-parser#1961 to capture this issue, and am working on a pull request to remedy. I would much prefer to fix this issue before the next release of the redfish-codegen crates, so that we can be on a fixed version of swagger-parser again, but I am willing to entertain releasing the software with these duplicated models if there is an appetite for a sooner release, since the duplicate models do not seem to produce build errors.

@AmateurECE AmateurECE changed the title Build Failure with swagger-parser v1.18.0 Duplicate Schemas with swagger-parser v1.18.0 Nov 9, 2023
@AmateurECE
Copy link
Owner Author

Since there's been no movement on swagger-api/swagger-parser#1961, I've decided to begin re-implementing the generator not to have this dependency. I'll track the progress of that work in #4, and leave this issue open until it is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant