Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing files in workspace #2682

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add missing files in workspace #2682

wants to merge 1 commit into from

Conversation

kpanot
Copy link
Contributor

@kpanot kpanot commented Jan 10, 2025

Proposed change

fix: add missing files in workspace

Related issues

@kpanot kpanot requested a review from a team as a code owner January 10, 2025 11:39
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 10, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit ee3162d.

Command Status Duration Result
nx run-many --target=test-e2e ❌ Failed 8m 24s View ↗
nx run-many --target=test-int ✅ Succeeded 58m 13s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded 1s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 1m 50s View ↗
nx run-many --target=build ✅ Succeeded 16m 12s View ↗
nx affected --target=test --collectCoverage ✅ Succeeded 37s View ↗
nx run-many --target=documentation ✅ Succeeded 1m 20s View ↗
nx affected --target=package-github-action ✅ Succeeded 2m 1s View ↗
Additional runs (3) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-16 16:21:33 UTC

@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.98%. Comparing base (3ffc0ba) to head (ee3162d).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...hematics/src/tasks/package-manager/npm-node-run.ts 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kpanot kpanot marked this pull request as draft January 10, 2025 14:20
@kpanot kpanot force-pushed the bugfix/editor-config-setup branch 14 times, most recently from c7d2deb to 562cb2f Compare January 15, 2025 05:18
@kpanot kpanot marked this pull request as ready for review January 15, 2025 05:23
@kpanot kpanot force-pushed the bugfix/editor-config-setup branch from 562cb2f to c27005d Compare January 15, 2025 09:49
@kpanot kpanot force-pushed the bugfix/editor-config-setup branch from c27005d to 5529303 Compare January 15, 2025 10:17
fpaul-1A
fpaul-1A previously approved these changes Jan 15, 2025
View reviewed changes
mrednic-1A
mrednic-1A previously approved these changes Jan 16, 2025
View reviewed changes
@kpanot kpanot dismissed stale reviews from mrednic-1A and fpaul-1A via ee3162d January 16, 2025 14:48
@kpanot kpanot force-pushed the bugfix/editor-config-setup branch from 5529303 to ee3162d Compare January 16, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpaul-1A fpaul-1A fpaul-1A approved these changes

@mrednic-1A mrednic-1A mrednic-1A left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working project:@o3r/schematics project:@o3r/workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Should @o3r/create generate a husky hooks configuration?
3 participants
@kpanot @mrednic-1A @fpaul-1A