From c0cde18b1ac456e29118132ee88c9f115cc44442 Mon Sep 17 00:00:00 2001
From: Ali Mihandoost <ali.mihandoost@gmail.com>
Date: Sat, 31 Aug 2024 20:33:31 +0330
Subject: [PATCH] refactor(CollectionReference): Rename `item__` method
 parameter from `id` to `itemId`

The `item__` method in the `CollectionReference` class has been updated to use the parameter name `itemId` instead of `id`. This change improves the clarity and readability of the code by using a more descriptive parameter name.

Co-authored-by: Mohammad Honarvar <honarvar.info@gmail.com>
---
 packages/reference/src/collection-reference.ts | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/packages/reference/src/collection-reference.ts b/packages/reference/src/collection-reference.ts
index 5724a39d..6f74dfdb 100644
--- a/packages/reference/src/collection-reference.ts
+++ b/packages/reference/src/collection-reference.ts
@@ -293,14 +293,14 @@ export class CollectionReference<TItem extends JsonifiableObject = JsonifiableOb
   /**
    * Retrieves an item from the collection. If the item does not exist, an error is thrown.
    *
-   * @param id - The ID of the item.
+   * @param itemId - The ID of the item.
    * @returns The item with the given ID.
    */
-  private item__(id: string | number): CollectionItem<TItem> {
-    const item = this.context__.data[id];
+  private item__(itemId: string | number): CollectionItem<TItem> {
+    const item = this.context__.data[itemId];
     if (item === undefined) {
-      this.logger__.accident('item_', 'collection_item_not_found', {id});
-      throw new Error('collection_item_not_found', {cause: {id}});
+      this.logger__.accident('item_', 'collection_item_not_found', {itemId});
+      throw new Error('collection_item_not_found', {cause: {itemId}});
     }
     return item;
   }
@@ -403,7 +403,7 @@ export class CollectionReference<TItem extends JsonifiableObject = JsonifiableOb
   append(data: TItem): string | number {
     this.logger__.logMethodArgs?.('append', data);
     const id = this.nextAutoIncrementId__();
-    this.create(id, data);
+    this.add(id, data);
     return id;
   }
 
@@ -580,7 +580,7 @@ export class CollectionReference<TItem extends JsonifiableObject = JsonifiableOb
     this.logger__.logMethodArgs?.('updated__', {id, immediate, delayed: this.updateDelayed_});
 
     this.hasUnprocessedChanges_ = true;
-    if (id !== null) this.updateMeta_(id); // meta must updated per item
+    if (id !== null) this.updateMetadata_(id); // meta must updated per item
 
     if (immediate === false && this.updateDelayed_ === true) return;
     // else
@@ -597,7 +597,7 @@ export class CollectionReference<TItem extends JsonifiableObject = JsonifiableOb
     if (this.updateDelayed_ !== true) return; // another parallel update finished!
     this.updateDelayed_ = false;
 
-    if (id === null) this.updateMeta_(id); // root meta not updated for null
+    if (id === null) this.updateMetadata_(id); // root meta not updated for null
 
     if (this._freeze === true) return; // prevent save if frozen
     this.updatedCallback__.call(null, this);