Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight issue with docs #2

Open
ryantheleach opened this issue Oct 15, 2024 · 3 comments
Open

Slight issue with docs #2

ryantheleach opened this issue Oct 15, 2024 · 3 comments

Comments

@ryantheleach
Copy link
Contributor

ryantheleach commented Oct 15, 2024

"IdeaProjects\praeter\praeter-plugin\build\libs\praeter-plugin-0.1-SNAPSHOT.jar"

preater-plugin was found inside praeter-plugin not praeter core.

Additionally, needed to add mavenLocal to repositories.

repositories {
    mavenLocal()
 }

It says to make an assets folder, but is it in the root project, or inside resources? This would be handy, as would the examples as plugin form, either in their own repository, or a sub folder in this one. I haven't worked it out yet, but I'm getting there.

@Alvinn8
Copy link
Owner

Alvinn8 commented Oct 15, 2024

You're right that the docs weren't very clear there, thanks for the feedback! The assets folder should be inside the src/main/resources folder. Were you able to get it all to work? I do have an example plugin / testing plugin that I use to test features, I can send the source code here for now so you can check how to do stuff, but I agree that adding an example plugin here or in another repo would help people understand how to use the project.
praeter-test.zip

@ryantheleach
Copy link
Contributor Author

Thanks, I wasn't expecting such a fast response.

I've been deep in learning best practices on shading, and stumbled down a rabbit hole, so been a little distracted, so the response was timely enough that I hadn't solved it yet!

I'll let you know how I go, but I don't want to be a burden.

@Alvinn8
Copy link
Owner

Alvinn8 commented Oct 15, 2024

Cool! Don't worry about being a burden, feel free to ask if you have more questions! I only think it's interesting to hear that people are finding the project and think it's interesting :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants