-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#76) Open connection with pre configured session #90
(#76) Open connection with pre configured session #90
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #90 +/- ##
==========================================
- Coverage 94.32% 94.28% -0.04%
==========================================
Files 4 4
Lines 581 612 +31
Branches 90 98 +8
==========================================
+ Hits 548 577 +29
- Misses 28 29 +1
- Partials 5 6 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@@ -13,7 +14,7 @@ | |||
from .py3270 import Emulator | |||
|
|||
|
|||
class x3270(object): | |||
class X3270(object): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed to change this name in order to mock the os_name in the unit tests. Since the only interface to the user is the Mainframe3270
class, I do not consider this to be a breaking change.
Give the user the ability to open a connection using a session file. Session files are an alternative way to set up a connection using x3270 resources.
The new
Open Connection From Session File
is meant to be an alternative forOpen Connection
.