Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#76) Open connection with pre configured session #90

Merged

Conversation

robinmatz
Copy link
Collaborator

Give the user the ability to open a connection using a session file. Session files are an alternative way to set up a connection using x3270 resources.

The new Open Connection From Session File is meant to be an alternative for Open Connection.

@robinmatz robinmatz added this to the 3.2 milestone Mar 25, 2023
@robinmatz robinmatz linked an issue Mar 25, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2023

Codecov Report

Patch coverage: 93.93% and project coverage change: -0.04 ⚠️

Comparison is base (10c4d31) 94.32% compared to head (a629b3e) 94.28%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
- Coverage   94.32%   94.28%   -0.04%     
==========================================
  Files           4        4              
  Lines         581      612      +31     
  Branches       90       98       +8     
==========================================
+ Hits          548      577      +29     
- Misses         28       29       +1     
- Partials        5        6       +1     
Flag Coverage Δ
acceptance 79.57% <66.66%> (-0.46%) ⬇️
unit 86.92% <66.66%> (-1.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Mainframe3270/x3270.py 99.08% <93.75%> (-0.58%) ⬇️
Mainframe3270/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -13,7 +14,7 @@
from .py3270 import Emulator


class x3270(object):
class X3270(object):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to change this name in order to mock the os_name in the unit tests. Since the only interface to the user is the Mainframe3270 class, I do not consider this to be a breaking change.

@samuelpcabral samuelpcabral merged commit e21910b into MarketSquare:master Mar 31, 2023
@robinmatz robinmatz deleted the open-connection-from-session-file branch April 1, 2023 12:24
@github-actions github-actions bot mentioned this pull request Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open connection with pre configured session
3 participants