Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#32) Enable setting screenshot file name prefix #81

Merged
merged 3 commits into from
Mar 3, 2023

Conversation

Harm10
Copy link
Contributor

@Harm10 Harm10 commented Feb 27, 2023

Added the option to set a file name prefix.

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (16884a8) 93.45% compared to head (f442251) 93.44%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage   93.45%   93.44%   -0.02%     
==========================================
  Files           4        4              
  Lines         581      580       -1     
  Branches       88       88              
==========================================
- Hits          543      542       -1     
  Misses         32       32              
  Partials        6        6              
Flag Coverage Δ
acceptance 75.17% <100.00%> (+0.12%) ⬆️
unit 87.93% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Mainframe3270/x3270.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Mainframe3270/x3270.py Outdated Show resolved Hide resolved
Mainframe3270/x3270.py Outdated Show resolved Hide resolved
@robinmatz robinmatz added the enhancement New feature or request label Feb 28, 2023
@robinmatz robinmatz added this to the 3.1 milestone Feb 28, 2023
@robinmatz robinmatz linked an issue Feb 28, 2023 that may be closed by this pull request
@Harm10
Copy link
Contributor Author

Harm10 commented Feb 28, 2023

@robinmatz BTW I am also working on Open connection to get the desired port from extra_args. You can also put it in there to open better options for different configurations.

@Harm10
Copy link
Contributor Author

Harm10 commented Mar 1, 2023

@robinmatz Can you please respond on my updated PR?

@robinmatz
Copy link
Collaborator

@Harm10 , I think I already did. I don't know why you didn't see my reply.

The only thing I asked was for you to run inv lint to ensure proper formatting of your source code ans to commit the modified files. After that, this PR is ready to be merged.

@Harm10
Copy link
Contributor Author

Harm10 commented Mar 3, 2023

Weird that your reply has been lost. Anyway I executed inv lint.

@robinmatz robinmatz changed the title Screenshot file name prefix (#32) Enable setting screenshot file name prefix Mar 3, 2023
if os.name == "nt":
assert filepath == r".\MyScreenshot_1000.html"
else:
assert filepath == "./MyScreenshot_1000.html"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Harm10 , could you run inv lint locally to ensure proper code formatting?

@robinmatz robinmatz merged commit f37baca into MarketSquare:master Mar 3, 2023
@robinmatz
Copy link
Collaborator

@Harm10 thanks alot for your work on this! I am thinking about when we to release the next version.

I am waiting for the bug fix #83 to be merged.

After that I think it's a good time to release version 3.1.

As for the other issues you raised, I think we should include them in 3.2

@Harm10
Copy link
Contributor Author

Harm10 commented Mar 3, 2023

@robinmatz I am working on another PR to get the port number that can be set in extra_args as well. For that I need some input from you when I create it. But I only have limited time so I would not let version 3.1 wait on it!

@github-actions github-actions bot mentioned this pull request Mar 15, 2023
@Harm10 Harm10 deleted the Screenshot_prefix branch March 25, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Set name prefix of screenshot
3 participants