-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#32) Enable setting screenshot file name prefix #81
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #81 +/- ##
==========================================
- Coverage 93.45% 93.44% -0.02%
==========================================
Files 4 4
Lines 581 580 -1
Branches 88 88
==========================================
- Hits 543 542 -1
Misses 32 32
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@robinmatz BTW I am also working on Open connection to get the desired port from extra_args. You can also put it in there to open better options for different configurations. |
@robinmatz Can you please respond on my updated PR? |
@Harm10 , I think I already did. I don't know why you didn't see my reply. The only thing I asked was for you to run |
Weird that your reply has been lost. Anyway I executed inv lint. |
utest/x3270/test_screenshot.py
Outdated
if os.name == "nt": | ||
assert filepath == r".\MyScreenshot_1000.html" | ||
else: | ||
assert filepath == "./MyScreenshot_1000.html" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Harm10 , could you run inv lint
locally to ensure proper code formatting?
@robinmatz I am working on another PR to get the port number that can be set in extra_args as well. For that I need some input from you when I create it. But I only have limited time so I would not let version 3.1 wait on it! |
Added the option to set a file name prefix.