Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#67) Create contributing guidelines #75

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

robinmatz
Copy link
Collaborator

@robinmatz robinmatz commented Feb 22, 2023

Resolves #67

@samuelpcabral - can you please review the contributing guidelines?

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Base: 94.82% // Head: 93.43% // Decreases project coverage by -1.40% ⚠️

Coverage data is based on head (e29d32b) compared to base (cd2d650).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   94.82%   93.43%   -1.40%     
==========================================
  Files           4        4              
  Lines         580      579       -1     
  Branches      106       87      -19     
==========================================
- Hits          550      541       -9     
- Misses         26       32       +6     
- Partials        4        6       +2     
Flag Coverage Δ
acceptance 74.09% <ø> (-5.05%) ⬇️
unit 87.91% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Mainframe3270/py3270.py 85.66% <0.00%> (-3.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@robinmatz robinmatz changed the title Create contribution guidelines and bug reporting issue template (#67) Create contribution guidelines Feb 25, 2023
@robinmatz robinmatz changed the title (#67) Create contribution guidelines (#67) Create contributing guidelines Feb 25, 2023
@robinmatz robinmatz marked this pull request as ready for review February 25, 2023 17:42
@samuelpcabral samuelpcabral merged commit 95cbf7c into MarketSquare:master Mar 15, 2023
@github-actions github-actions bot mentioned this pull request Mar 15, 2023
@robinmatz robinmatz deleted the 67 branch March 16, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create contributing guidelines
3 participants