Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency 'six' #68

Merged
merged 3 commits into from
Aug 19, 2022
Merged

remove dependency 'six' #68

merged 3 commits into from
Aug 19, 2022

Conversation

samuelpcabral
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022

Codecov Report

Merging #68 (996c692) into master (911cdc0) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   94.83%   94.82%   -0.01%     
==========================================
  Files           4        4              
  Lines         581      580       -1     
  Branches      106      106              
==========================================
- Hits          551      550       -1     
  Misses         26       26              
  Partials        4        4              
Flag Coverage Δ
acceptance 79.31% <0.00%> (+0.13%) ⬆️
unit 87.93% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Mainframe3270/x3270.py 100.00% <ø> (ø)
Mainframe3270/py3270.py 88.72% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 911cdc0...996c692. Read the comment docs.

@samuelpcabral samuelpcabral added this to the 3.1 milestone Aug 1, 2022
@samuelpcabral
Copy link
Member Author

@robinmatz can you take a look in the code coverage please?

@samuelpcabral
Copy link
Member Author

@robinmatz can you take a look in the code coverage please?

Oh forget it, when I made the merge request the code coverage was telling me that it would drop to -3.48% now after the end of actions the value changed to -0.01%

@robinmatz
Copy link
Collaborator

robinmatz commented Aug 1, 2022

Hi @samuelpcabral , no problem. Just finished the review, only minor remarks from my point of view.

I think it would be better to rename the pr to "remove dependency 'six'", or something like that.

@samuelpcabral samuelpcabral changed the title Small fixies remove dependency 'six' Aug 19, 2022
@samuelpcabral samuelpcabral merged commit cd2d650 into master Aug 19, 2022
@samuelpcabral samuelpcabral deleted the small_fixies branch March 15, 2023 15:45
@github-actions github-actions bot mentioned this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants