Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all Robot Framework time formats (#65) #66

Merged
merged 5 commits into from
Jul 21, 2022

Conversation

robinmatz
Copy link
Collaborator

@robinmatz robinmatz commented Jul 16, 2022

Resolves #65

Todo:

  • Implement feature
  • Write utests
  • Update docs
  • Fix atests

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2022

Codecov Report

Merging #66 (0630d40) into master (76b589d) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   94.77%   94.83%   +0.06%     
==========================================
  Files           4        4              
  Lines         574      581       +7     
  Branches      105      106       +1     
==========================================
+ Hits          544      551       +7     
  Misses         26       26              
  Partials        4        4              
Flag Coverage Δ
acceptance 79.69% <79.41%> (+0.24%) ⬆️
unit 87.95% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Mainframe3270/__init__.py 100.00% <100.00%> (ø)
Mainframe3270/x3270.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76b589d...0630d40. Read the comment docs.

@robinmatz robinmatz marked this pull request as ready for review July 20, 2022 19:15
@robinmatz robinmatz added this to the 3.1 milestone Jul 20, 2022
@robinmatz robinmatz added the enhancement New feature or request label Jul 20, 2022
@samuelpcabral samuelpcabral merged commit 911cdc0 into MarketSquare:master Jul 21, 2022
@robinmatz robinmatz deleted the issue-65 branch July 24, 2022 07:40
@github-actions github-actions bot mentioned this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set timeout as time strings
3 participants