Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#112 Implement find string keyword #114

Merged
merged 8 commits into from
Oct 20, 2023
Merged

Conversation

robinmatz
Copy link
Collaborator

@robinmatz robinmatz commented Oct 15, 2023

Resolves #112

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c51d59c) 96.50% compared to head (c3a4aff) 97.06%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   96.50%   97.06%   +0.55%     
==========================================
  Files          12       12              
  Lines         716      750      +34     
  Branches      161      170       +9     
==========================================
+ Hits          691      728      +37     
+ Misses         20       18       -2     
+ Partials        5        4       -1     
Flag Coverage Δ
acceptance 84.93% <74.28%> (-0.13%) ⬇️
unit 92.53% <100.00%> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
Mainframe3270/keywords/commands.py 100.00% <100.00%> (+6.97%) ⬆️
Mainframe3270/keywords/read_write.py 100.00% <100.00%> (ø)
Mainframe3270/py3270.py 92.73% <100.00%> (+0.42%) ⬆️
Mainframe3270/utils.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuelpcabral
Copy link
Member

samuelpcabral commented Oct 18, 2023

Hi @robinmatz there is some conflits.. can you check? I think is just keep both changes, but I want to double check with you. Thanks

@robinmatz
Copy link
Collaborator Author

@samuelpcabral - I will set this PR to draft. There are some adjustments I want to make to improve consistency with the other PR #113 , that you just merged.

@robinmatz robinmatz changed the title #112 Implement find string keyword Draft: #112 Implement find string keyword Oct 18, 2023
@samuelpcabral samuelpcabral merged commit ea4b133 into MarketSquare:master Oct 20, 2023
3 of 4 checks passed
@robinmatz robinmatz changed the title Draft: #112 Implement find string keyword #112 Implement find string keyword Oct 21, 2023
@robinmatz robinmatz deleted the 112 branch December 16, 2023 06:11
@github-actions github-actions bot mentioned this pull request Dec 21, 2023
@github-actions github-actions bot mentioned this pull request Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search screen and return x/ypos
3 participants