-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#31) Setup the emulator model #107
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #107 +/- ##
==========================================
- Coverage 96.71% 96.06% -0.65%
==========================================
Files 12 12
Lines 700 712 +12
Branches 96 94 -2
==========================================
+ Hits 677 684 +7
- Misses 19 24 +5
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@@ -1,8 +1,10 @@ | |||
import re | |||
from typing import List, Optional | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samuelpcabral , I am sorry, I know you removed these line breaks, but they are inserted automatically by isort
and I haven't yet figured out how to prevent the tool from doing this.
I hope this is not an issue
The tests are failing because currently there are some announcements on pub400 that also include the string "pub400". This happens periodically, so I think I will change our acceptance tests to look for strings that are less likely to change. |
I think the last commits fixed the pipeline, except for the host disconnected error, which we have no influence on, since pub400.com blocks too many requests from the same IP. I saw that the unit tests on windows take oddly long, and I think it has to do with some tests in test_connection.py. I will fix those and then this PR is ready from my point of view. |
This would be my take on issue #31,
As you can see in the documentation, I propose that we publish this as an experimental feature, so that users are aware that this feature is not yet stable.