Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#31) Setup the emulator model #107

Merged
merged 19 commits into from
Jun 14, 2023
Merged

Conversation

robinmatz
Copy link
Collaborator

@robinmatz robinmatz commented Jun 10, 2023

This would be my take on issue #31,
As you can see in the documentation, I propose that we publish this as an experimental feature, so that users are aware that this feature is not yet stable.

@robinmatz robinmatz added the enhancement New feature or request label Jun 10, 2023
@robinmatz robinmatz added this to the 4.0 milestone Jun 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.65 ⚠️

Comparison is base (2cab2ba) 96.71% compared to head (76d3536) 96.06%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
- Coverage   96.71%   96.06%   -0.65%     
==========================================
  Files          12       12              
  Lines         700      712      +12     
  Branches       96       94       -2     
==========================================
+ Hits          677      684       +7     
- Misses         19       24       +5     
  Partials        4        4              
Flag Coverage Δ
acceptance 84.55% <89.39%> (+0.69%) ⬆️
unit 91.29% <100.00%> (-2.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Mainframe3270/keywords/commands.py 100.00% <ø> (ø)
Mainframe3270/keywords/read_write.py 100.00% <ø> (ø)
Mainframe3270/utils.py 100.00% <ø> (ø)
Mainframe3270/__init__.py 100.00% <100.00%> (ø)
Mainframe3270/keywords/__init__.py 100.00% <100.00%> (ø)
Mainframe3270/keywords/assertions.py 100.00% <100.00%> (ø)
Mainframe3270/keywords/connection.py 98.82% <100.00%> (+0.01%) ⬆️
Mainframe3270/keywords/screenshot.py 100.00% <100.00%> (ø)
Mainframe3270/keywords/wait_and_timeout.py 100.00% <100.00%> (ø)
Mainframe3270/librarycomponent.py 100.00% <100.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -1,8 +1,10 @@
import re
from typing import List, Optional

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samuelpcabral , I am sorry, I know you removed these line breaks, but they are inserted automatically by isort and I haven't yet figured out how to prevent the tool from doing this.

I hope this is not an issue

@robinmatz
Copy link
Collaborator Author

The tests are failing because currently there are some announcements on pub400 that also include the string "pub400". This happens periodically, so I think I will change our acceptance tests to look for strings that are less likely to change.

@robinmatz
Copy link
Collaborator Author

robinmatz commented Jun 11, 2023

I think the last commits fixed the pipeline, except for the host disconnected error, which we have no influence on, since pub400.com blocks too many requests from the same IP.

I saw that the unit tests on windows take oddly long, and I think it has to do with some tests in test_connection.py. I will fix those and then this PR is ready from my point of view.

@samuelpcabral samuelpcabral merged commit ff67c11 into MarketSquare:master Jun 14, 2023
@github-actions github-actions bot mentioned this pull request Jun 16, 2023
@robinmatz robinmatz deleted the 31 branch October 23, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants