(#103) Provide absolute URLs to files in README #104
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #104 +/- ##
==========================================
- Coverage 95.00% 94.98% -0.03%
==========================================
Files 4 4
Lines 621 618 -3
Branches 96 92 -4
==========================================
- Hits 590 587 -3
Misses 27 27
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@robinmatz If you make these links absolute they will no longer work on a local clone without internet connection or behind a firewall. I do not see the advantage of making them absolute as their content will be in the clone as well. |
|
@Harm10 , the problem is when you try to use these links when on pypi.org. You can try the link to the contributing guidelines on the page I linked. You might be right that the links won't work locally without internet. However, as pypi.org might be one place where people find the project for the first time, I think having broken links there is worse to user experience than the problem you mentioned. |
|
@robinmatz I see the problem on pypi. But isn't that a problem of pypi itself? |
Closes #103