Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable description search in Dashboard #13837

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Enable description search in Dashboard #13837

wants to merge 3 commits into from

Conversation

ErlingHauan
Copy link
Contributor

@ErlingHauan ErlingHauan commented Oct 21, 2024 •
edited
Loading

SSB wishes to search for their repo's description. This PR enables that.

The keyword -datamodels is excluded from the description search. This prevents DataModelsRepoList from displaying repos with the keyword -datamodels only in the description (edge case). Repos named something-datamodels will still show in the data models repo list.

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@ErlingHauan ErlingHauan linked an issue Oct 21, 2024 that may be closed by this pull request
Enable description search in Dashboard #13825
Open
2 tasks
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. backend labels Oct 21, 2024
@ErlingHauan ErlingHauan changed the title Enable description search in Dashboard feat: Enable description search in Dashboard Oct 21, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (31d5ec1) to head (c1b9019).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #13837   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files        1648     1648           
  Lines       21956    21956           
  Branches     2581     2581           
=======================================
  Hits        20924    20924           
  Misses        787      787           
  Partials      245      245

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nkylstad
nkylstad approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkylstad nkylstad nkylstad approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
backend solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-core
Projects
Team Studio
Status: 🧪 Test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable description search in Dashboard
2 participants
@ErlingHauan @nkylstad