Don't redefine macros with OCaml 4.12 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Macros `Val_none` and `Some_val` are part of the standard library starting with OCaml 4.12. In some environments, redefining a macro triggers a compiler warning. When warnings are treated as errors, the build fails. Issue discussing the introduction of the macros, the problem, and the fix: ocaml/ocaml#5154 Commit introducing the macros in the standard library: ocaml/ocaml@973eeb1
MisterDA
added a commit
to MisterDA/ocaml
that referenced
this pull request
Jul 2, 2020
If an OCaml C library already defines some of the new `Val_none`,
`Some_val`, `Is_none`, `Is_some`, `caml_alloc_some`, or `Tag_some`
macros; then the C compiler will likely warn for macro redefinition,
even if the macro definition are identical. In some setups that always
turn warnings to errors, this will block the compilation of the
library.
This problem happens in [ocaml-mccs][1].
The proposed [fix][2] for libraries is to only define the macros when
compiling with OCaml strictly older than 4.12, i.e.:
#if OCAML_VERSION < 41200
#define ...
#endif
[1]: ocaml-opam/ocaml-mccs#30
[2]: ocaml#5154 (comment)
MisterDA
added a commit
to MisterDA/ocaml
that referenced
this pull request
Jul 17, 2020
If an OCaml C library already defines some of the new `Val_none`,
`Some_val`, `Is_none`, `Is_some`, `caml_alloc_some`, or `Tag_some`
macros; then the C compiler will likely warn for macro redefinition,
even if the macro definition are identical.
This problem happens in [ocaml-mccs][1].
The proposed [fix][2] for libraries is to only define the macros when
compiling with OCaml strictly older than 4.12, i.e.:
#if OCAML_VERSION < 41200
#define ...
#endif
[1]: ocaml-opam/ocaml-mccs#30
[2]: ocaml#5154 (comment)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macros
Val_noneandSome_valare part of the standard librarystarting with OCaml 4.12.
In some environments, redefining a macro triggers a compiler warning.
When warnings are treated as errors, the build fails.
Issue discussing the introduction of the macros, the problem, and the
fix: ocaml/ocaml#5154
Commit introducing the macros in the standard library:
ocaml/ocaml@973eeb1