Update to GLPK 4.65 #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterDA
force-pushed
the
glpk-4.65
branch
4 times, most recently
from
79385c9
to
a87fced
Compare
GLPK has a slightly daft way of identifying MSVC-specific blocks of code, in that its nmake files define __WOE__ explicitly, rather than just using the MSVC_specific _MSC_VER define (note that mingw-w64 builds do *not* define __WOE__). This commit reapplies 2d05aca on top of the GLPK 4.65 update.
|
Is the second commit (changing the sources) strictly required? When vendoring, it's better to keep the patches only to the ones which must happen. |
|
GLPK 5.0 was released in December, so we should try to do that as well |
|
I don't remember... I was irritated by the CI failing and it appeared it didn't really need the glpk update for what I was working on at the time. Updating GLPK seems the best option. |
|
Thanks a lot! I just integrated this (manually) into master ; On a test case I get more than x2 steedup on opam resolution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLPK 4.65 was released on Thu Feb 16 10:00:00 2018, and is present in Debian Buster (stable).