Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify x11/x11-dl crates with dlib #149

Open
Be-ing opened this issue Feb 14, 2022 · 2 comments
Open

unify x11/x11-dl crates with dlib #149

Be-ing opened this issue Feb 14, 2022 · 2 comments

Comments

@Be-ing
Copy link

Be-ing commented Feb 14, 2022

Since #7, the x11-dl crate uses dlopen instead of direct linking. This split of crates is odd and confusing. I think dlib would be a better solution. It allows the user of the library to decide at build time via a Cargo option whether to link or dlopen.

@AltF02
Copy link
Owner

AltF02 commented Feb 15, 2022

Yeah I was looking into maybe using bindgen aswell

There's just an small issue unifying, alot of packages depend on x11-dl, which means that I would probably have to deploy 2 packages per version. I could maybe a warning in the build.rs though

@Be-ing
Copy link
Author

Be-ing commented Feb 15, 2022

Yeah, I suggest to put

compile_error!("This crate has been unified with the x11 crate. Switch to the x11 crate and enable its `dlopen` feature.");

in x11-dl's build.rs when releasing the merged crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants